Skip to content

Conversation

@Martinxux
Copy link
Contributor

@Martinxux Martinxux commented Aug 16, 2024

PR Title

CSV to Excel Refactor & Fix

Summary

summary...

  • 🎨Refactor: Remove redundant code
  • 🐛Fix: The get_sheet_by_name method in the class Workbook has been deprecated

Description

Some of the code looks redundant and I don't think it's needed.
The "get_sheet_by_name" method in class "Workbook" is deprecated and "workbook[sheet_name]" should be used

The changes are as follows:

  • 🎨Refactor: Remove redundant code and add some exegesis
  • 🐛Fix: The get_sheet_by_name method in the class Workbook has been deprecated

Checks

in the repository

  • Made no changes that degrades the functioning of the repository
  • Gave each commit a better title (unlike updated README.md)

in the PR

  • Followed the format of the pull_request_template
  • Made the Pull Request in a small level (for the creator's wellfare)
  • Tested the changes you made

Thank You,

Martinxu

@DhanushNehru DhanushNehru merged commit 10e474a into wasmerio:master Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants